Skip to content

Fix parent type of Visitor #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2020
Merged

Fix parent type of Visitor #18

merged 2 commits into from
Jul 10, 2020

Conversation

@Murderlon
Copy link
Member

@Murderlon Murderlon commented Jul 10, 2020

Fixes #17

ChristianMurphy
ChristianMurphy approved these changes Jul 10, 2020
View reviewed changes
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Murderlon

@Murderlon @ChristianMurphy
Apply feedback
d1d58c0 
Co-authored-by: Christian Murphy <[email protected]>
@Murderlon Murderlon merged commit 8cd97bd into main Jul 10, 2020
@Murderlon Murderlon deleted the bugfix/#17 branch July 10, 2020 14:10
@ChristianMurphy ChristianMurphy added ☂️ area/types This affects typings 👶 semver/patch This is a backwards-compatible fix 🦋 type/enhancement This is great to have 🐛 type/bug This is a problem labels Jul 10, 2020
@wooorm wooorm added ⛵️ status/released and removed 🦋 type/enhancement This is great to have labels Jul 11, 2020
@wooorm
Copy link
Member

wooorm commented Jul 11, 2020

Sweet, thanks, released!

@wooorm wooorm added the 💪 phase/solved Post is done label Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristianMurphy ChristianMurphy ChristianMurphy approved these changes

Assignees

No one assigned

Labels

☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Types]: type of parent should be Parent

4 participants

@Murderlon @wooorm @ChristianMurphy